Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(pie-cookie-banner): DSW-2387 updated visual test refactors #2107

Merged
merged 11 commits into from
Dec 16, 2024
Merged

test(pie-cookie-banner): DSW-2387 updated visual test refactors #2107

merged 11 commits into from
Dec 16, 2024

Conversation

JoshuaNg2332
Copy link
Contributor

@JoshuaNg2332 JoshuaNg2332 commented Dec 4, 2024 •
edited by jamieomaguire
Loading

Describe your changes (can list changeset entries if preferable)

  • Updated pie-cookie-banner visual tests with official Playwright package usage.
  • Added turbo.json file to not require builds for tests as they are now reliant on the deployment.

Note: Had to edit the test to push the modal component that lives within Cookie Banner for the manage preferences functionality up within the test due to a bug that doesn't affect the main modal component. Edit is shown within screenshots below.

Before After
Screenshot 2024-12-05 at 12 24 57 Screenshot 2024-12-11 at 12 23 08

Author Checklist (complete before requesting a review, do not delete any)

  • I have performed a self-review of my code.
  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have reviewed visual test updates properly before approving.

Reviewer checklists (complete before approving)

Mark items as [-] N/A if not applicable.

Reviewer 1 - @siggerzz

  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have verified that all acceptance criteria for this ticket have been completed.
  • [-] N/A I have reviewed the Aperture changes (if added)
  • If there are visual test updates, I have reviewed them.

Reviewer 2

  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have verified that all acceptance criteria for this ticket have been completed.
  • [-] N/A I have reviewed the Aperture changes (if added)
  • If there are visual test updates, I have reviewed them.

@JoshuaNg2332 JoshuaNg2332 requested review from a team as code owners December 4, 2024 11:36
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 4, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 3036dc8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@JoshuaNg2332 JoshuaNg2332 force-pushed the DSW-2397-cookie-banner-refactor branch from a38fd65 to 224aa47 Compare December 12, 2024 14:16
@JoshuaNg2332 JoshuaNg2332 changed the title test(pie-cookie-banner): DSW-2397 updated visual test refactors test(pie-cookie-banner): DSW-2387 updated visual test refactors Dec 12, 2024
@JoshuaNg2332 JoshuaNg2332 merged commit bbf4112 into main Dec 16, 2024
31 of 34 checks passed
@JoshuaNg2332 JoshuaNg2332 deleted the DSW-2397-cookie-banner-refactor branch December 16, 2024 11:15
@raoufswe raoufswe mentioned this pull request Jan 14, 2025
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamieomaguire jamieomaguire jamieomaguire approved these changes

@siggerzz siggerzz siggerzz approved these changes

Assignees
No one assigned
Labels
apps components pie-cookie-banner pie-storybook
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoshuaNg2332 @siggerzz @jamieomaguire